4.x branch is no longer maintained we can't use 5.x because we still support IE11 and transpiling is not recommended by the author because it hasn't been tested video support? (there seems to be workarounds ) + well defined location for action buttons + supports in-line gallery mode but only for the 4.x unmaintained branch + provides enough space for large image description / caption out of the box I'm worried about the limited space for the image caption + jump to any image from the gallery using its thumbnail + supports in-line gallery mode out of the box requires hacks for in-line gallery mode + supports large image description / caption out of the box I think the minimalistic characteristic of the library is another plus, making it easier to follow and maintain. ImageLightBox).Įven if, as I said, Photoswipe is one of the top choices, I find it a real disadvantage that we should use v4 until v5 is release, considering that v5 will come with a complete rewrite in ES6 and this could mean a lot of changes in the way the library is used by us and time invested for working on it.Ĭonsidering this and also the last added column, I propose to use SimpleLightbox, given also that it is the only one that was already moved to modern javascript. Regarding tests, it is specified that only one of them has written tests (i.e. For clarity, I added more details for this inside the design page under Lightbox display customizations and code style, along with some information regarding the possibility to understand and modify the code. Last, since you spent time to look at them, what would be your recommendation?Īll of them have customization options, meaning that there is a functionality that provides a way to modify the design of the lightbox. Or rather redo a list, excluding those that are not license-compatible maybe. So I think we need to have a list from 1 to 8. You haven’t mentioned the licenses for most of them BTW, could you do that (and remove those that don’t have a license compatible with XWiki’s?Īlso you restarted the list at 1 but we already had 4 listed previously. whether there are tests that can help us make sure we don’t break stuff when we make changesĪlso note that since this is about possibly including this feature in XS, we need a compatible license and for example, GPL is not going to work.how easy it is to read the code and be able to modify it.Thus, it seems we’ll need to pick a framework based on 2 criteria mostly: It’s going to be hard to pick one for which we can have a good likelihood that it’ll still be supported, in, 1 or 2 years from now. with more than 20 commits over the past 6 months, that’s roughly one commit per week which is the low end to what we could call active IMO).įrom a quick look these projects seem to be a one-man effort mostly with several not active for several months. number of active committers for the past 6 months (e.g.number of releases across 2 years and mean # of releases per year for 20.Would be nice if you could indicate the following info: specifies browser and mobile support (v5-beta works only on modern browsers).
0 Comments
Leave a Reply. |